#2977: [patch] Better handling of regular expressions for reverse urlresolver
---------------------------+------------------------------------------------
Reporter: SmileyChris | Owner: adrian
Status: new | Component: Core framework
Version: | Resolution:
Keywords: | Stage: Design decision needed
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
---------------------------+------------------------------------------------
Comment (by mtredinnick):
This ticket is a good example of why separate issues should be in separate
bugs. You are trying to do many things at once and it makes it hard to
split out the good from the not so good and discuss each issue in
isolation. That being said, let's work with what you've done (since it's
an impressive effort):
Fixes 1, 3 and 5 are all fine. They're just small cleanups. That can be a
single patch.
Fix 2 is a design decision and I think you're making the wrong decision.
Allowing keyword and positional args to mix (not nest, but be in the same
reg-exp) is fine.
Fix 4, I need to think about some more.
I'll commit portions and make a decision on the rest in the next couple of
days. No need to write a new patch, I can see what you're doing in the
current code and it will be easy to tease it apart.
--
Ticket URL: <http://code.djangoproject.com/ticket/2977#comment:10>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
