#3185: Allow django.contrib.auth's LOGIN_URL, LOGOUT_URL and ACCOUNT_URL to be
set
in settings.py
------------------------------------------------------+---------------------
Reporter: Vasily Sulatskov <[EMAIL PROTECTED]> | Owner:
adrian
Status: new | Component:
Contrib apps
Version: SVN | Resolution:
Keywords: | Stage:
Accepted
Has_patch: 1 | Needs_docs:
0
Needs_tests: 0 | Needs_better_patch:
1
------------------------------------------------------+---------------------
Changes (by mtredinnick):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
The most recent patch still has a few subtle problems:
1. Anything that is configurable should always be read from settings, not
shoved in as a constant into some other module (it's not a constant any
longer, after all). I realise LOGIN_URL is already a constant in the auth
module, but that now becomes a proxy for the value from settings for
backwards compatibility reasons. Everything else comes straight out of
settings (including all current internal uses of LOGIN_URL).
2. We should not be reading anything from settings at import time; only
at execution time. The reason for this is manually configured settings.
The developer needs to be able to import the necessary modules and then
call {{{settings.configure()}}}. The current code reads from settings at
import time and so will raise a configuration error. This problem exists
in other parts of Django as well, but that's not a reason to perpetuate
the problem.
--
Ticket URL: <http://code.djangoproject.com/ticket/3185#comment:20>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
