#19772: Redirects don't honor APPEND_SLASH
-----------------------------------+--------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: contrib.redirects | Version: 1.4
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by carljm):
Yes, that's what I was about to say.
But I still agree with you that it seems like `RedirectFallbackMiddleware`
ought to be trying with an added slash, not a removed one, in this case,
since `APPEND_SLASH` would never actually have appended a slash in this
situation. IOW `RedirectFallbackMiddleware` needs to have its own
implementation of `APPEND_SLASH`, not reverse its effect like the current
code seems to be trying to do.
Unfortunately adding a slash while retaining querystring is a bit uglier
than removing, but doable.
I have no idea how this would have broken with the recent dp.com changes.
--
Ticket URL: <https://code.djangoproject.com/ticket/19772#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
