#11295: If ModelAdmin.queryset returns a filtered QS don't require a 2nd count
call
--------------------------------------+------------------------------------
Reporter: Alex | Owner: viciu
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by viciu):
I've updated patch so it applies correctly on current master.
Also, test in original patch assumes that there are 6 queries to db
(including messages framework).
Currently, before applying patch there are 5 of them (including duplicated
COUNT(*):
{{{
(Pdb) pprint(connection.queries)
[{'sql': 'QUERY = \'SELECT "django_session"."session_key",
"django_session"."session_data", "django_session"."expire_date" FROM
"django_session" WHERE ("django_session"."session_key" = %s AND
"django_session"."expire_date" > %s )\' - PARAMS =
(\'2nj8364ycp90oge7xl5tf9mviz7grety\', \'2013-02-23 17:53:11.374277\')',
'time': '0.000'},
{'sql': 'QUERY = \'SELECT "auth_user"."id", "auth_user"."password",
"auth_user"."last_login", "auth_user"."is_superuser",
"auth_user"."username", "auth_user"."first_name", "auth_user"."last_name",
"auth_user"."email", "auth_user"."is_staff", "auth_user"."is_active",
"auth_user"."date_joined" FROM "auth_user" WHERE "auth_user"."id" = %s \'
- PARAMS = (100,)',
'time': '0.001'},
{'sql': 'QUERY = \'SELECT COUNT(*) FROM "admin_views_emptymodel" WHERE
"admin_views_emptymodel"."id" > %s \' - PARAMS = (1,)',
'time': '0.000'},
{'sql': 'QUERY = \'SELECT COUNT(*) FROM "admin_views_emptymodel" WHERE
"admin_views_emptymodel"."id" > %s \' - PARAMS = (1,)',
'time': '0.000'},
{'sql': 'QUERY = \'SELECT "admin_views_emptymodel"."id" FROM
"admin_views_emptymodel" WHERE "admin_views_emptymodel"."id" > %s ORDER
BY "admin_views_emptymodel"."id" DESC\' - PARAMS = (1,)',
'time': '0.000'}]
}}}
After patch was applied, COUNT(*) is executed once:
{{{
(Pdb) pprint(connection.queries)
[{'sql': 'QUERY = \'SELECT "django_session"."session_key",
"django_session"."session_data", "django_session"."expire_date" FROM
"django_session" WHERE ("django_session"."session_key" = %s AND
"django_session"."expire_date" > %s )\' - PARAMS =
(\'5y65r95ng27kccdmkrtoo1qom7q4vhln\', \'2013-02-23 17:54:51.024189\')',
'time': '0.000'},
{'sql': 'QUERY = \'SELECT "auth_user"."id", "auth_user"."password",
"auth_user"."last_login", "auth_user"."is_superuser",
"auth_user"."username", "auth_user"."first_name", "auth_user"."last_name",
"auth_user"."email", "auth_user"."is_staff", "auth_user"."is_active",
"auth_user"."date_joined" FROM "auth_user" WHERE "auth_user"."id" = %s \'
- PARAMS = (100,)',
'time': '0.001'},
{'sql': 'QUERY = \'SELECT COUNT(*) FROM "admin_views_emptymodel" WHERE
"admin_views_emptymodel"."id" > %s \' - PARAMS = (1,)',
'time': '0.000'},
{'sql': 'QUERY = \'SELECT "admin_views_emptymodel"."id" FROM
"admin_views_emptymodel" WHERE "admin_views_emptymodel"."id" > %s ORDER
BY "admin_views_emptymodel"."id" DESC\' - PARAMS = (1,)',
'time': '0.000'}]
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/11295#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
