#17320: Sites.domain should not contain whitespace
--------------------------------------+------------------------------------
     Reporter:  jnovinger             |                    Owner:  zerok
         Type:  Cleanup/optimization  |                   Status:  assigned
    Component:  contrib.sites         |                  Version:  1.3
     Severity:  Normal                |               Resolution:
     Keywords:  sprint2013            |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  1
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by zerok):

 * keywords:   => sprint2013
 * needs_better_patch:  0 => 1
 * owner:  krzysiumed => zerok


Comment:

 Personally, I believe that validating regarding spaces alone should be
 sufficient (unless we want to go for an all-out domain-name validation)
 but the current patch marks the whole model as invalid and not just the
 domain field. Also, since this is a user-facing validation message, it
 should be localized.

 So the question raised above remains: Do we only need space-validation or
 should we go for an all-out domain name validation for this field?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17320#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to