#20288: admin popup querystring inconsistency
-----------------------------------------+--------------------
Reporter: Keryn Knight <django@…> | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------------+--------------------
* The `ChangeList` objects, as well as `get_actions` both use the variable
`IS_POPUP_VAR` (defined in the same module as `ChangeList`) whose value is
the string `pop`
* The `change_view`, `add_view`, `response_add`, `response_change` instead
use a hard-coded string value `_popup`
This should be refactored because it is fragile and inconsistent, and
means one cannot annotate links with `?popup_variable=1` to get the admin
view without the masthead etc, because using `_popup` on the ChangeList
will force it to redirect to `?e=1` (not a valid filter lookup), and using
`pop` on the other views won't do the desired thing.
--
Ticket URL: <https://code.djangoproject.com/ticket/20288>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
