#20025: Do something for MySQL under Python 3
---------------------------------+-------------------------------------
     Reporter:  aaugustin        |                    Owner:  aaugustin
         Type:  Bug              |                   Status:  assigned
    Component:  Python 3         |                  Version:  master
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  1
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+-------------------------------------
Changes (by aaugustin):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 It turns out that the tests don't pass...

 I made a few fixes and updated the pull request. The only remaining
 problem pertains to `BinaryField`.

 {{{
 ======================================================================
 ERROR: test_set_and_retrieve (model_fields.tests.BinaryFieldTests)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File "/Users/myk/Documents/dev/django/tests/model_fields/tests.py", line
 450, in test_set_and_retrieve
     self.assertEqual(bytes(dm.data), bytes(bdata))
 TypeError: string argument without an encoding
 }}}

 (There's also three failures in the `serializers_regress` tests but they
 have the same root cause.)

 `pdb` shows that `dm.data` is `"b'\\x00F\\xfe'"` instead of
 `b'\x00F\xfe'`. In other words, `str()` or `force_str()` was incorrectly
 applied to the value.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20025#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to