#20541: Differenciate user from superuser creation in django.contrib.auth at a
signal level
--------------------------------------+------------------------------------
     Reporter:  antonio@…             |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.auth          |                  Version:  1.5
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by russellm):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I fully accept that the underlying problem -- that saving a superuser
 involves 2 saves -- should be solved. I'm just not completely convinced
 about the solution. The extra save=True argument seems messy to me.

 Personally, I'd rather see the 'guts' of create_user factored out into in
 internal method that is called by both create_user and create_superuser -
 that way, the public call to create_user would end up looking a lot like
 create_superuser, but with reversed boolean values.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20541#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.4583b9e13df6d0e9fef5c8b89fd3b94f%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to