#18134: BoundField.label_tag should include form.label_suffix
-------------------------------------+-------------------------------------
Reporter: Evil Clay | Owner:
<clay.evil@…> | gabejackson
Type: | Status: closed
Cleanup/optimization | Version: 1.4
Component: Forms | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: forms | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"584bd14dcfdee9585fec7794d53ce120ea73d0bc"]:
{{{
#!CommitTicketReference repository=""
revision="584bd14dcfdee9585fec7794d53ce120ea73d0bc"
Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.
This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18134#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/089.c412ffa1d0a6f2615505e6bf5341686d%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
