#14930: `values_list()` fails on queryset ordered by extra column
-------------------------------------+-------------------------------------
     Reporter:  lsaffre              |                    Owner:  fhahn
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Ready for
     Keywords:                       |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by fhahn):

 Thanks for the feedback, I've updated the patch. I've pushed the changes
 to my own branch at the moment
 
(https://github.com/fhahn/django/commit/025ad76b97b90fc45eae8a18dfb4ad58c3dcbe58),
 because I wasn't sure if I should open another pull request for the
 django/django repo.

 The self.extra_names is not None check was there before and something (not
 related to the test cases added by the patch) breaks if the condition is
 replaced by self.extra_names. I'm not sure where exactly, but I could have
 a closer look next week or so.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/14930#comment:29>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.aa8a497a1e7822297c614c255c086f5c%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to