#20657: Have UserChangeForm and UserCreationForm utilize get_user_model()
--------------------------------------+--------------------
     Reporter:  ChocolateCookies      |      Owner:  nobody
         Type:  Cleanup/optimization  |     Status:  new
    Component:  Uncategorized         |    Version:  1.5
     Severity:  Normal                |   Keywords:
 Triage Stage:  Unreviewed            |  Has patch:  0
Easy pickings:  0                     |      UI/UX:  0
--------------------------------------+--------------------
 While I was trying to re-use the creation form for the admin interface
 with my custom User model (derived from {{{AbstractUser}}}), I stumbled
 upon an issue, namely I couldn't re-use it. I might have thought of a
 solution, but it's probably not very elegant.

 In {{{contrib.auth.forms}}} the model meta property for
 {{{UserChangeForm}}} is User, but in for example AuthenticationForm, the
 method {{{get_user_model}}} is utilized. Consequently I cannot use the
 form, because this class imports auth.User instead of my own User model.
 Is this on purpose, or would it be possible to extend AUTH_USER_MODEL to
 the creation and change forms?

 I would say it is only possible if a custom User model is derived from
 {{{AbstractUser}}}, as opposed to {{{AbstractBaseUser}}}
 ([https://docs.djangoproject.com/en/1.5/topics/auth/customizing/#specifying-a
 -custom-user-model Like the Django docs suggest]). {{{AbstractUser}}}
 guarantees the fields that these forms use (username, email), while
 {{{AbstractBaseUser}}} doesn't. Although that takes away a lot of the
 flexibility of specifying a custom User model, so maybe there's a middle
 ground somewhere.

 contrib/auth/forms.py:
 {{{
 class UserChangeForm(forms.ModelForm):
 ...
     class Meta:
         model = User
 ...
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20657>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/059.96783635e667e5b198c962c9a8f46595%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to