#20660: Filefield.delete() on empty field delete MEDIA_ROOT
--------------------------------------+------------------------------------
     Reporter:  stanislas.guerra@…    |                    Owner:  nobody
         Type:  Bug                   |                   Status:  new
    Component:  File uploads/storage  |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:  FileField delete      |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by claudep):

 * version:  1.4 => master
 * stage:  Unreviewed => Accepted


Comment:

 I could reproduce this. And yes, the deletion succeeds only when
 MEDIA_ROOT is a symlink (when it's a real directory, it will fail with
 `OSError: [Errno 21] Is a directory: ...` at least on Linux).

 I tend to think there are two bugs:
  * `FieldFile` should not call `storage.delete` when `self._file` is None
  * `FileSystemStorage` should not try to remove a path when its `delete`
 method receives `''` as argument.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20660#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.252c75e2cfa48ef4ac156bc5b6b983e4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to