Author: mtredinnick
Date: 2007-04-25 04:44:06 -0500 (Wed, 25 Apr 2007)
New Revision: 5074

Modified:
   django/trunk/django/contrib/admin/views/decorators.py
   django/trunk/django/contrib/auth/__init__.py
Log:
Fixed #3379 -- Changed login() so that we update last_login when a user
logs in. Thanks, arvin.


Modified: django/trunk/django/contrib/admin/views/decorators.py
===================================================================
--- django/trunk/django/contrib/admin/views/decorators.py       2007-04-25 
09:34:29 UTC (rev 5073)
+++ django/trunk/django/contrib/admin/views/decorators.py       2007-04-25 
09:44:06 UTC (rev 5074)
@@ -90,8 +90,6 @@
             if user.is_active and user.is_staff:
                 login(request, user)
                 # TODO: set last_login with an event.
-                user.last_login = datetime.datetime.now()
-                user.save()
                 if request.POST.has_key('post_data'):
                     post_data = _decode_post_data(request.POST['post_data'])
                     if post_data and not post_data.has_key(LOGIN_FORM_KEY):

Modified: django/trunk/django/contrib/auth/__init__.py
===================================================================
--- django/trunk/django/contrib/auth/__init__.py        2007-04-25 09:34:29 UTC 
(rev 5073)
+++ django/trunk/django/contrib/auth/__init__.py        2007-04-25 09:44:06 UTC 
(rev 5074)
@@ -1,3 +1,4 @@
+import datetime
 from django.core.exceptions import ImproperlyConfigured
 
 SESSION_KEY = '_auth_user_id'
@@ -48,6 +49,8 @@
     if user is None:
         user = request.user
     # TODO: It would be nice to support different login methods, like signed 
cookies.
+    user.last_login = datetime.datetime.now()
+    user.save()
     request.session[SESSION_KEY] = user.id
     request.session[BACKEND_SESSION_KEY] = user.backend
 


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to