#20917: Change the password hashers when testing
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner:
Type: New feature | ashchristopher
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 0 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by ashchristopher):
Discussed this issue with `julienphalip` on irc (#django-sprints) and we
both think that maybe this isn't actually something Django should have an
opinion on.
{{{
[10:40:54] <+julienphalip> ashc: So I'm feeling a bit divided about
#20917.
[10:40:54] <ticketbot> https://code.djangoproject.com/ticket/20917
[10:41:07] <ashc> julienphalip: re: #20917, I am not even sure if it is a
real code problem
[10:41:08] <ticketbot> https://code.djangoproject.com/ticket/20917
[10:41:21] <ashc> part of me thinks it is a documentation issue
[10:41:32] <+julienphalip> ashc: I think so too
[10:41:34] <ashc> or rather, a "this is how you should do tests" problem
[10:42:06] <ashc> some people just rely on settings.py + local_setting.py
and others (like us) have a special testing_settings.py file we use
[10:42:17] <ashc> and that is where we override the PASSWORD_HASHERS
[10:42:30] <+julienphalip> ashc: Yep
[10:42:56] <+julienphalip> I think it's best to let users consciously
change the hashers setting for testing
[10:43:28] <ashc> Is there anything we can do to make this more clear for
people? Does Django have an opinion on test settings files?
[10:44:44] <+julienphalip> ashc: I'm all for speeding up tests' execution,
but if we enforced a weak hasher then I'd like to be sure there can be no
weird surprise and no discrepancy between the test and production
environments.
[10:45:14] <+julienphalip> ashc: I don't think Django as a project has any
particular recommendation. There are many different techniques....
[10:48:08] <ashc> julienphalip: I am thinking things are kind of ok as
they are, and maybe we just close the ticket with an explanation that
Django shouldn't have an opinion on this matter, and that there is
documentation that will allow developers to apply the speed fixes
themselves?
[10:49:32] <+julienphalip> ashc: I tend to agree. It'd be great to have a
chat with mjtamlyn about this first to see what he thinks.
[10:51:43] <+julienphalip> ashc: This section could be beefed up with more
tips as well:
https://docs.djangoproject.com/en/dev/topics/testing/overview/#speeding-
up-the-tests
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20917#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.5bfa85335bfe728beecb926cb555ee2c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
