#21197: 1.6 compatibility checks don't correctly validate TEST_RUNNER
-------------------------------------+-------------------------------------
Reporter: russellm | Owner: nobody
Type: Bug | Status: new
Component: Core | Version: 1.6-alpha-1
(Management commands) | Keywords:
Severity: Release | Has patch: 0
blocker | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
The 1.6 compatibility checks (executed by the new check management
command) don't appear to perform an accurate check.
I can see 5 scenarios that need to be accounted for:
1. A default pre-Django 1.6 project
2. A pre-Django 1.6 project with TEST_RUNNER set to DiscoverRunner
3. A pre-Django 1.6 project with TEST_RUNNER set to something custom
4. A default Django 1.6 project
5. A Django 1.5 project with TEST_RUNNER set to something custom
The management command does the following:
{{{
from django.conf import settings
new_default = 'django.test.runner.DiscoverRunner'
test_runner_setting = getattr(settings, 'TEST_RUNNER', new_default)
if test_runner_setting == new_default:
... output warning ...
}}}
That is, it retrieves the current setting value of TEST_RUNNER, and if it
is DiscoverRunner, it raises a warning. This behavior:
* Is correct for case 1
* Is possibly incorrect for case 3 and 5, as there's no guarantee the
custom test runner subclasses DiscoverRunner (and it probably won't)
* Incorrectly raises an error for case 2 and 4.
There are test cases for the current implementation, but they aren't very
solid - they're operating inside a test environment that is itself force
setting TEST_RUNNER.
--
Ticket URL: <https://code.djangoproject.com/ticket/21197>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/051.579dc8ef18e1475691d95d3adada4acc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
