#21249: Typo in SQLCompiler.get_grouping()
----------------------------------------------+--------------------
Reporter: manfre | Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+--------------------
From
https://github.com/django/django/blob/master/django/db/models/sql/compiler.py#L578
{{{
for order, order_params in ordering_group_by:
# Even if we have seen the same SQL string, it might
have
# different params, so, we add same SQL in "has
params" case.
if order not in seen or params:
result.append(order)
params.extend(order_params)
seen.add(order)
}}}
should be:
{{{
for order, order_params in ordering_group_by:
# Even if we have seen the same SQL string, it might
have
# different params, so, we add same SQL in "has
params" case.
if order not in seen or order_params:
result.append(order)
params.extend(order_params)
seen.add(order)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21249>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/049.cde005585ca2a83f67582ce7af48532e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
