#21428: Django 1.6 GenericRelation editable regression
-------------------------------------+-------------------------------------
Reporter: joshcartme | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.6
(models, ORM) | Resolution:
Severity: Release blocker | Triage Stage: Accepted
Keywords: GenericRelation, | Needs documentation: 0
ModelForm, Admin, editable | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by akaariai):
Editable GenericRelations weren't designed to work in modelforms, and I
guess that is the reason why there is zero tests for this. To see that
GenericRelations try to avoid to be editable, see
`GenericRelation.__init__` which explicitly overrides editable to False.
But as Mezzanine relies on this and I don't see any way to overcome this
in Mezzanine I think we should fix this in Django.
I have a proposed patch that just adds virtual fields to modelforms if
they are editable. I wonder if this is enough to make Mezzanine work in
1.6?
Patch against 1.6 available from
https://github.com/akaariai/django/compare/django:stable%2F1.6.x...ticket_21428.
--
Ticket URL: <https://code.djangoproject.com/ticket/21428#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.5a2d92714925707d0cebcbd27a518805%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
