#21431: Django 1.6 GenericRelation admin list_filter regression
---------------------------------+------------------------------------
Reporter: stephenmcd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.6
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by akaariai):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
A proposed patch for 1.6.x in
https://github.com/akaariai/django/commit/c895dd39ae4e7687b57ff01ecfcc27caf70323ed.
There are two issues I am concerned with:
- Is the tests in the correct place, and are the inline models the
correct way forward?
- Is there more similar regressions in admin? The get_field_by_name()
method is used a lot for constructing relations, path names etc. Maybe
some of those are affected too.
In general the admin code should be DRYed up a little when it comes to
relation path generation.
For master the elif branches in admin/util.py could be removed, it
shouldn't be hit at all, but for 1.6 could cause more regressions
(shouldn't, but can't assert it doesn't).
--
Ticket URL: <https://code.djangoproject.com/ticket/21431#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.a10aabf37b5109fef998f779ff13ad53%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
