#21592: formset.ordered_forms should try to return ordered forms if is_valid() 
is
false
-------------------------------+-------------------------------------
     Reporter:  nickname123    |                    Owner:  pjrharley
         Type:  Uncategorized  |                   Status:  assigned
    Component:  Forms          |                  Version:  1.6
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  1              |                    UI/UX:  0
-------------------------------+-------------------------------------

Comment (by nickname123):

 I think the patch needs to do just a little more.  If the form isn't valid
 then cleaned_data will raise an exception won't it?  Unless that changed
 in more recent versions of django.  I'm stuck on an older version with the
 project I am currently working with.

 I got around this by falling back to using form.data.  See line 33 of the
 file I attached.  This still doesn't work for forms without data.  It
 makes sense to me for initial forms to have an ordering as well as it
 might be nice for ordered forms to return all forms that aren't deleted
 for easy rendering in templates.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21592#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.539a32368b5fbe1af6305cd58735eb34%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to