#4189: Fix for COMMENTS_BANNED_USERS_GROUP exploding the ORM when using the
templatetag.
-------------------------------------------------------------+--------------
Reporter: Brett Hoerner <[EMAIL PROTECTED]> | Owner:
adrian
Status: new |
Component: django.contrib.comments
Version: 0.96 |
Resolution:
Keywords: comments, COMMENTS_BANNED_USERS_GROUP |
Stage: Unreviewed
Has_patch: 1 |
Needs_docs: 0
Needs_tests: 0 |
Needs_better_patch: 0
-------------------------------------------------------------+--------------
Changes (by Jeremy Dunck <[EMAIL PROTECTED]>):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
We found one more issue while using comments with 0.96 and
settings.COMMENTS_BANNED_USERS_GROUP /
settings.COMMENTS_SKETCHY_USERS_GROUP.
I'm attaching a combined patch.
To be clear, the bugs reported here aren't obvious to other people using
the comments framework because the framework short-circuits around the
problem areas if settings does not include a truth-y related *_USERS_GROUP
setting.
There don't seem to be any tests on the comments app, or I'd add tests to
cover this particular edge case.
--
Ticket URL: <http://code.djangoproject.com/ticket/4189#comment:1>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
