#21852: Migration serializer cannot handle iterators
----------------------------+---------------------------------------------
     Reporter:  MarkusH     |                    Owner:  MarkusH
         Type:  Bug         |                   Status:  assigned
    Component:  Migrations  |                  Version:  master
     Severity:  Normal      |               Resolution:
     Keywords:              |             Triage Stage:  Ready for checkin
    Has patch:  0           |      Needs documentation:  0
  Needs tests:  0           |  Patch needs improvement:  0
Easy pickings:  0           |                    UI/UX:  0
----------------------------+---------------------------------------------
Changes (by bmispelon):

 * stage:  Unreviewed => Ready for checkin


Comment:

 I can reproduce the issue.

 The proposed patch looks good: the added test fails with current master
 and passes after applying the patch.

 I wonder however if `collections.Iterator` should be used instead of
 `collections.Iterable`, but that's just nitpicking.

 I'll mark this as `ready for checkin` and try to get a second set of eyes
 to check it out before committing.

 Thanks.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21852#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0055ff235ef55d4e09ddca1dd467863c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to