#785: many2many table and legacy databases.
-------------------------------+--------------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: mtredinnick
Status: new | Component: Database wrapper
Version: SVN | Resolution:
Keywords: | Stage: Accepted
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 1
-------------------------------+--------------------------------------------
Changes (by [EMAIL PROTECTED]):
* needs_docs: 1 => 0
* needs_tests: 1 => 0
Comment:
Replying to [comment:8 russellm]:
> Three comments:
Thank you for reviewing my patch
> 1) This should be attached as a file to the ticket, rather than copied
into a comment
Sorry won't happen again. I missed it because I was looing for attach
button near comment entry field.
> 2) The m2m test at the end is currently testing db_table. By changing
that option, you are removing the regression test for the db_table
setting. Don't remove an existing test, just add a new one (e.g., another
m2m relation in that model, with some logic taking the relation for a
walk).
Added new test case as suggested. Walked the relation from both tables.
> 3) Documentation! There needs to be an entry on the db-api page on these
settings. This documentation should be part of your patch.
Thank you for reminding me that. I have added doc entries in model-api
page.
Attached patch file : ''m2m_column_names.patch''
--
Ticket URL: <http://code.djangoproject.com/ticket/785#comment:9>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
