#22534: Checks fail on non-swappable ForeignKeys when the related model is
swapped
out
---------------------------------+--------------------------------------
Reporter: bendavis78 | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.7-beta-2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by bendavis78):
This is my initial attempt to fix this. It passes current tests but it
still needs tests for `swappable=None/True/False` (which I can do soon):
https://github.com/bendavis78/django/commit/cc70dd04fcc2a36592a6896b253c6adda8651cf4
The current change fixes the issue for startup checks, however I'm not
100% sure what should be done with migrations, if anything. Migrations
will still fail if a foreign key points to a swappable model that has been
swapped out (regardless of whether or not its a string). It may be that it
should stay this way but I'd probably need someone to chime in on that.
Not sure if I'm on the right track here, or even if this bug would
realistically effect anyone else (I do have a workaround for my use case).
--
Ticket URL: <https://code.djangoproject.com/ticket/22534#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.046ab5e33a0d0210f8404b15bdb194dc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.