#22799: GET and POST on HttpRequest should be QueryDicts
--------------------------------------+------------------------------------
Reporter: duncan@… | Owner: duncan
Type: Cleanup/optimization | Status: closed
Component: HTTP handling | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"fd4ccd045cf8edf0bf10ee0c576c7b7c5819170c"]:
{{{
#!CommitTicketReference repository=""
revision="fd4ccd045cf8edf0bf10ee0c576c7b7c5819170c"
Fixed #22799 -- Made GET and POST on HttpRequest QueryDicts, and FILES a
MultiValueDict.
Previously, GET, POST, and FILES on an HttpRequest were created in
the __init__ method as dictionaries. This was not something you would
usually notice causing trouble in production as you'd only see a
WSGIRequest, but in testing using the test client, calling .getlist
on GET, POST, or FILES for a request with no get/post data resulted in
an AttributeError.
Changed GET and POST on an HttpRequest object to be mutable
QueryDicts (mutable because the Django tests, and probably many
third party tests, were expecting it).
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22799#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/078.2a1326b053bacac8c03aa647267e80a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
