#21648: Deprecate "is_admin_site" option of auth.views.password_reset()
--------------------------------------+------------------------------------
     Reporter:  brain@…               |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.auth          |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by timgraham):

 * type:  Bug => Cleanup/optimization
 * has_patch:  0 => 1
 * version:  1.6 => master
 * component:  Documentation => contrib.auth


Comment:

 Deprecation looks reasonable to me. I couldn't find a use case for it
 because if `contrib.sites` isn't installed,
 `contrib.sites.requests.RequestSite` (via `get_current_site()` in
 `PasswordResetForm`) uses `request.get_host()` as well.

 [https://github.com/django/django/pull/3083 PR]

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21648#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/082.c6cba17e877aaa7d98b63bf40d233a02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to