#4497: Bug if form_url is empty (i.e. creating new user), and
TEMPLATE_STRING_IF_INVALID is set
-----------------------------------------+----------------------------------
Reporter: buriy <[EMAIL PROTECTED]> | Owner: adrian
Status: closed | Component: Admin
interface
Version: SVN | Resolution: wontfix
Keywords: | Stage: Unreviewed
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
-----------------------------------------+----------------------------------
Changes (by mtredinnick):
* status: new => closed
* resolution: => wontfix
Old description:
> Index: D:/program/Python24/Lib/site-packages/django-
> svn/django/contrib/admin/templates/admin/change_form.html
> ===================================================================
> --- D:/program/Python24/Lib/site-packages/django-
> svn/django/contrib/admin/templates/admin/change_form.html (revision
> 5418)
> +++ D:/program/Python24/Lib/site-packages/django-
> svn/django/contrib/admin/templates/admin/change_form.html (working
> copy)
> @@ -23,7 +23,7 @@
> </ul>
> {% endif %}{% endif %}
> {% endblock %}
> -<form {% if has_file_field %}enctype="multipart/form-data" {% endif
> %}action="{{ form_url }}" method="post" id="{{ opts.module_name
> }}_form">{% block form_top %}{% endblock %}
> +<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}{%
> if form_url %}action="{{ form_url }}" {% endif %}method="post" id="{{
> opts.module_name }}_form">{% block form_top %}{% endblock %}
> <div>
> {% if is_popup %}<input type="hidden" name="_popup" value="1" />{% endif
> %}
> {% if opts.admin.save_on_top %}{% submit_row %}{% endif %}
New description:
{{{
Index: D:/program/Python24/Lib/site-packages/django-
svn/django/contrib/admin/templates/admin/change_form.html
===================================================================
--- D:/program/Python24/Lib/site-packages/django-
svn/django/contrib/admin/templates/admin/change_form.html (revision
5418)
+++ D:/program/Python24/Lib/site-packages/django-
svn/django/contrib/admin/templates/admin/change_form.html (working
copy)
@@ -23,7 +23,7 @@
</ul>
{% endif %}{% endif %}
{% endblock %}
-<form {% if has_file_field %}enctype="multipart/form-data" {% endif
%}action="{{ form_url }}" method="post" id="{{ opts.module_name
}}_form">{% block form_top %}{% endblock %}
+<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}{%
if form_url %}action="{{ form_url }}" {% endif %}method="post" id="{{
opts.module_name }}_form">{% block form_top %}{% endblock %}
<div>
{% if is_popup %}<input type="hidden" name="_popup" value="1" />{% endif
%}
{% if opts.admin.save_on_top %}{% submit_row %}{% endif %}
}}}
Comment:
(fixed ticket description)
The admin interface depends on TEMPLATE_STRING_IF_INVALID being empty.
There is another ticket open to remove that dependence, but for now it
exists. Fixing it piecemeal is not going to be very effective.
--
Ticket URL: <http://code.djangoproject.com/ticket/4497#comment:2>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
