#3436: Don't fetch Field's choices on form/manipulator creation
----------------------------------------------------------+-----------------
Reporter: Ivan Sagalaev <[EMAIL PROTECTED]> | Owner:
adrian
Status: new |
Component: Core framework
Version: SVN |
Resolution:
Keywords: performance |
Stage: Accepted
Has_patch: 1 |
Needs_docs: 0
Needs_tests: 0 |
Needs_better_patch: 1
----------------------------------------------------------+-----------------
Comment (by mtredinnick):
A small comment about this change (since I've looked at it, but don't have
cycles to complete the work at the moment)...
I looked at this patch a couple of weeks ago. It wasn't immediately clear
where the performance improvement appeared. It's definitely an improvement
for some uses, but are we hitting those uses in newforms?
So we need a test to demonstrate how this is triggered, I think. It's a
slight backwards incompatible change (since the returned type of
get_choices changes). It wasn't apparent when I moved Joe Heck's example
from #2638 over to newforms, for example.
--
Ticket URL: <http://code.djangoproject.com/ticket/3436#comment:8>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
