#23581: Migration shouldn't generate "DROP DEFAULT" SQL if no database changes 
are
required
--------------------------------------+------------------------------------
     Reporter:  john_scott            |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Migrations            |                  Version:  1.7
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by shaib):

 * cc: shaib (added)


Comment:

 John: I think Andrew is mostly correct. You can probably fix things by
 editing the Django-CMS migrations to set the field attributes from
 settings, the same way your models do. Then, they will have the correct
 values per installation. Changing the relevant settings may still require
 a migration, and probably should.

 It may be possible to set things up so migrations are auto-generated in
 these cases with settings references, similarly to the way they take
 swappable models into account. If you can come up with a reasonable API
 that will serve this purpose, I think it will be considered favorably.

--
Ticket URL: <https://code.djangoproject.com/ticket/23581#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.cc3416b00be8c13be76eb5c6acc3467e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to