#23656: FormMixin.get_form's form_class argument should be optional
------------------------------------------------+------------------------
Reporter: charettes | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Generic views | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Just like we do with `SingleObjectMixin.get_object(queryset=None)` that
defaults on `get_queryset()` we should make
`FormMixin.get_form(form_class)` default on `get_form_class` to make
overriding easier.
The provided patch introduces a backward compatibility issue for users
that overrided `get_form()` on a `ProcessFormView` subclass and expected
`form_class` to be `not None`. It could be addressed by removing the
changes in `ProcessFormView.get()` and `ProcessFormView.post()`.
--
Ticket URL: <https://code.djangoproject.com/ticket/23656>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.984b09335c85ab5b66e3fd45f7eb6a96%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
