#23679: varchar(255) converted into varchar(255) NOT NULL after inspectdb 
followed
by migrate
-------------------------------------+-------------------------------------
     Reporter:  paulcdejean          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Core (Management     |                  Version:  1.7
  commands)                          |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:                       |      Needs documentation:  0
    Has patch:  0                    |  Patch needs improvement:  0
  Needs tests:  0                    |                    UI/UX:  0
Easy pickings:  0                    |
-------------------------------------+-------------------------------------

Comment (by claudep):

 inspectdb output has to be reviewed in all cases. For me, the choice is:

 * keep the current output and add a comment like: `# Field was detected as
 NULL, but we didn't add null=True, see
 https://docs.djangoproject.com/en/stable/ref/models/fields/#null`

 * change the output to let `null=True` and add the comment: `# Read
 https://docs.djangoproject.com/en/stable/ref/models/fields/#null and
 consider removing null=True`

 I'm currently favoring the second option.

--
Ticket URL: <https://code.djangoproject.com/ticket/23679#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.f87044f0636b22c2f2000c0a010d3e6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to