#23682: Stronger redirect loop detection in the test client
-----------------------------------+--------------------------------------
Reporter: wrwrwr | Owner: nobody
Type: Uncategorized | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by wrwrwr):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0
Comment:
[https://github.com/wrwrwr/django/compare/ticket_23682 Proposed changes]:
* defined a new `CircularRedirectError`;
* changed the loop detection to throw the exception on repeated URLs and
chains longer than 20;
* added a "redirect to self" test with a changing query argument.
Could all the loop prevention tests maybe live in `test_client` rather
than `test_client_regress`?
--
Ticket URL: <https://code.djangoproject.com/ticket/23682#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.fa965783549b8d382753e3c8fd4f8547%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
