#23663: Commands classes are not properly testable due to their initialization 
in
execute() method!
-------------------------------------+-------------------------------------
     Reporter:  daveoncode           |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |                  Version:  1.7
    Component:  Core (Management     |               Resolution:
  commands)                          |             Triage Stage:  Accepted
     Severity:  Normal               |      Needs documentation:  0
     Keywords:  test, tdd,           |  Patch needs improvement:  1
  management, commands               |                    UI/UX:  0
    Has patch:  1                    |
  Needs tests:  0                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by claudep):

 * needs_better_patch:  0 => 1


Comment:

 I'd really like to address this issue in a separate pull request. Moreover
 the commit you reference is a mix of code and stylistic changes, which
 makes it hard to review, especially in tests. Could you please work on
 that separation?

--
Ticket URL: <https://code.djangoproject.com/ticket/23663#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0d32696b41f38d3871e8b406f08393b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to