#23829: `ping_google` uses hardcoded http protocol
-------------------------------------+-------------------------------------
Reporter: jwa | Owner: dbrgn
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Documentation | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: sitemaps, | Needs documentation: 1
ping_google | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by burhan):
This does not change the scheme, it just changes the URL. The scheme is
hard coded (see
https://github.com/django/django/blob/master/django/contrib/sitemaps/__init__.py#L42).
In addition, this relies on `django.contrib.sites`, which is not enabled
by default.
I would like to propose a fix to this which adds two optional commands to
the `ping_google` method:
* `is_secure`, which will flag for https:// (defaults to `False`)
* `site_domain` which can be used to pass in the domain if
`django.contrib.sites` is not used.
Here are my proposed changes:
https://github.com/burhan/django/tree/ticket_23829
--
Ticket URL: <https://code.djangoproject.com/ticket/23829#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/061.ed8a91760cf0c5d66e4ce57479c26c41%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
