#10414: select_related ignores unrecognized fields
-------------------------------------+-------------------------------------
     Reporter:  trebor74hr           |                    Owner:  nip3o
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  select_related       |      Needs documentation:  0
    Has patch:  1                    |  Patch needs improvement:  1
  Needs tests:  1                    |                    UI/UX:  0
Easy pickings:  1                    |
-------------------------------------+-------------------------------------
Changes (by akaariai):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * easy:  0 => 1


Comment:

 I'll mark patch needs improvement as there needs to be tests for the
 following cases:
   - .select_related('tags') where tags is a GenericRelation
   - .select_related('content_object') where content_object is a
 GenericForeignKey()
   - .select_related('m2m_field') where m2m_field is a ManyToManyField
   - .select_related('reverse_foreign_key') where reverse_foreign_key is a
 non-unique reverse side of a foreign key

 These are easy additions to write to the test suite, so I'll mark this as
 easy pickings (the whole patch isn't easy, but the needed additions to the
 current patch are).

--
Ticket URL: <https://code.djangoproject.com/ticket/10414#comment:27>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8a1cfbb83aea823ccef9eceb9ca0156a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to