#20349: Don't load django.test when not testing
--------------------------------------+------------------------------------
Reporter: CollinAnderson | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by timgraham):
Regarding the second option, here's the comment from
`django.test.signals`:
{{{
# Most setting_changed receivers are supposed to be added below,
# except for cases where the receiver is related to a contrib app.
}}}
I don't really like the idea of `django.test` making special allowances
for contrib apps (okay, that's not the case now, but let's not add more of
it!).
I'm not sure there are any practical problems with moving the
`setting_changed` signal into core (is it more a purity argument that
users might construe that it can be used for more than testing)?
"Needs tests" is checked, but I am not really sure that is relevant (how
can we check `django.test` is not loaded while we are testing?!).
--
Ticket URL: <https://code.djangoproject.com/ticket/20349#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.cea3bd3311038965fbd6647b40483485%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.