#23931: db_manager() method doesn't increment creation_counter
-------------------------------------+-------------------------------------
Reporter: rhettg | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.7
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by rhettg):
I think it does make sense to allow creation of a manager with db or hints
directly rather than relying on the copy behavior.
However,
1. That's obviously a bit more involved since BaseManager doesn't
currently take any arguments and sub-classing is a really popular pattern.
It could conceivable cause problems for people.
1. That doesn't mean this patch isn't also correct. I don't think it's
appropriate to have any 'copy' patterns that don't increment the
creation_counter.
So maybe this patch is appropriate for backporting (since not incrementing
the counter is a bug), while adding arguments to init would be a valid for
a release?
--
Ticket URL: <https://code.djangoproject.com/ticket/23931#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.0b72ab8baf5c5c7c71dd4bb47dbac4f4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
