#24164: Oracle GIS geoapp extent test failure
---------------------------+-------------------------------------
     Reporter:  timgraham  |                    Owner:  timgraham
         Type:  Bug        |                   Status:  assigned
    Component:  GIS        |                  Version:  1.8alpha1
     Severity:  Normal     |               Resolution:
     Keywords:  oracle     |             Triage Stage:  Accepted
    Has patch:  1          |      Needs documentation:  0
  Needs tests:  0          |  Patch needs improvement:  0
Easy pickings:  0          |                    UI/UX:  0
---------------------------+-------------------------------------

Comment (by claudep):

 OK, just tested it with my patch and \o/, this works, albeit with this
 complementary change:
 {{{
 #!diff
 diff --git a/django/db/models/sql/compiler.py
 b/django/db/models/sql/compiler.py
 index b92855f..5f41a12 100644
 --- a/django/db/models/sql/compiler.py
 +++ b/django/db/models/sql/compiler.py
 @@ -464,7 +464,7 @@ class SQLCompiler(object):
          if obj.low_mark == 0 and obj.high_mark is None and not
 self.query.distinct_fields:
              # If there is no slicing in use, then we can safely drop all
 ordering
              obj.clear_ordering(True)
 -        return obj.get_compiler(connection=self.connection).as_sql()
 +        return
 obj.get_compiler(connection=self.connection).as_sql(subquery=True)

      def get_default_columns(self, start_alias=None, opts=None,
 from_parent=None):
          """
 }}}
 I guess we can assume that `subquery` is always True when `as_sql` is
 called from `as_nested_sql`. I can add this change in my patch, or it can
 be added in the current one, as you wish, Tim.

--
Ticket URL: <https://code.djangoproject.com/ticket/24164#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cf78862a50881db790c003a5fa85f2f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to