#24562: Test failure: Pickleability
-------------------------------------------+------------------------
               Reporter:  shaib            |          Owner:  nobody
                   Type:  Bug              |         Status:  new
              Component:  Utilities        |        Version:  1.8
               Severity:  Release blocker  |       Keywords:
           Triage Stage:  Unreviewed       |      Has patch:  0
    Needs documentation:  0                |    Needs tests:  0
Patch needs improvement:  0                |  Easy pickings:  1
                  UI/UX:  0                |
-------------------------------------------+------------------------
 Following the version bump to 1.8.1, we have failures on
 `test_unsupported_unpickle (queryset_pickle.tests.PickleabilityTestCase)`
 and `test_unsupported_unpickle
 (model_regress.test_pickle.ModelPickleTestCase)`. The problem is arguably
 in the test code: Both tests assume that
 `django.utils.version.get_major_version()` returns a `x.y` string, but
 that is only true for .0 minor versions -- and so the tests broke on the
 version bump to 1.8.1.

 I'm not quite sure about the fix --
 `django.utils.version.get_major_version()` looks like a public interface
 but it is not documented as far as I could see; it hasn't changed in a
 long time, but its return value is unintuitive, and I would expect the
 same as the author(s) of these tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/24562>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.88a8c82c6aba5bc94b8829568a57d781%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to