#24664: TemporaryFileUploadHandler new_file() does not match its parent class
-------------------------------+--------------------
Reporter: ddanier | Owner: nobody
Type: Uncategorized | Status: new
Component: Core (Other) | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
TemporaryFileUploadHandler.new_file(self, file_name, *args, **kwargs)
vs.
FileUploadHandler.new_file(self, field_name, file_name, content_type,
content_length, charset=None, content_type_extra=None)
TemporaryFileUploadHandler.new_file will take "file_name" as its first
argument and pass this (still as first argument) to
FileUploadHandler.new_file. So the argument will end up
FileUploadHandler.field_name, which is wrong.
I think a valid fix would be to remove file_name from
TemporaryFileUploadHandler.new_file as the parameter is not used besides
for calling the parent class. It may have been used for passing it to
TemporaryUploadedFile, but this must be history. I'll attach a patch to
change this.
--
Ticket URL: <https://code.djangoproject.com/ticket/24664>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.5e94cac7e7acfed5621f89f6b1b072c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
