#24744: hstore lookup fails inside subquery
----------------------------------+------------------------------------
Reporter: mrAdm | Owner:
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.8
Severity: Release blocker | Resolution:
Keywords: hstore | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Comment (by akaariai):
Seems like a case where KeyTransform will need a custom relabeled_clone
method. We should check other new lookups, transforms and expressions to
see if they contain this same bug.
This is quite common bug, I have seen a variation of missing or broken
relabeled_clone method a dozen times. The aliases of a query are not
relabeled for normal queries, so normal testing doesn't spot these issues.
The author needs to manually write a test for subquery support, and this
is too easy to forget.
Any ideas how we could automate testing of expression-likes so that we
automatically check relabeled_clone() support? The optimal solution would
be that whenever a new expression-like is introduced, we automatically
test that for relabeled_clone(). But this needs some sort of magic
autodetection, and I don't have any ideas how we could do this without
ugly hacks.
The alternate solution is to always test subquery support manually.
--
Ticket URL: <https://code.djangoproject.com/ticket/24744#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.50718a7dfaae1f181637468e0f386784%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
