#24854: Clean up django.db.models.query._values()
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
The `django.db.models.query._values()` method looks like it does much more
than it should be doing in the frontend query class. We should try to move
most of the method into `django.db.models.sql.query` so that other
backends are able to have a better chance of replacing it's functionality.
It might also be worth seeing how much of the method can be factored with
`sql.has_results` since they both setup the query in similar ways.
This comment sparked the idea:
https://github.com/django/django/pull/4706#issuecomment-105130864
--
Ticket URL: <https://code.djangoproject.com/ticket/24854>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/051.0a4e9b14308b1f82d2c1f14c0ba1abaa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
