#24968: ModelAdmin scrollbar problem when actions=None
-------------------------------------+-------------------------------------
     Reporter:  zauddelig            |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  contrib.admin        |                  Version:  1.8
     Severity:  Normal               |               Resolution:
     Keywords:  changelist, css      |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by zauddelig):

 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Old description:

> Having a class like this:
>
> {{{
> class MyModelAdmin(admin.ModelAdmin):
>     actions = None
> }}}
>
> Will lead to a list view with single column table and an unexpected
> horizontal scrollbar.
> The problem appears with Opera.
>
> To my opinion the problem is with this line in
> `django/contrib/admin/static/admin/css/changelists.css`:
>
> {{{
> #changelist table tbody td:first-child, #changelist table tbody th:first-
> child {
>     border-left: 0;
>     border-right: 1px solid #ddd;
> }
> }}}
>
> this not takes in consideration when we have `th:first-child` that is
> also a `last-child` the proposed solution is to add this rule:
>
> {{{
> #changelist table tbody th:first-child:last-child {
>     border-right: 0;
> }
> }}}

New description:

 Having a class like this:

 {{{
 class MyModelAdmin(admin.ModelAdmin):
     actions = None
 }}}

 Will lead to a list view with single column table and an unexpected
 horizontal scrollbar.
 The problem appears with Opera.

 To my opinion the problem is with this line in
 `django/contrib/admin/static/admin/css/changelists.css`:

 {{{
 #changelist table tbody td:first-child, #changelist table tbody th:first-
 child {
     border-left: 0;
     border-right: 1px solid #ddd;
 }
 }}}

 this not takes in consideration when we have `th:first-child` that is also
 a `last-child` the proposed solution is to add this rule:

 {{{
 #changelist table tbody th:first-child:last-child {
     border-right: 0;
 }
 }}}

 pull request:
 https://github.com/django/django/pull/4849

--

--
Ticket URL: <https://code.djangoproject.com/ticket/24968#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5ad8c980373d661f67ed7dbdf6ba0386%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to