#24944: Have password_reset pass extra_context to the email template rendering as well ------------------------------+--------------------------------------- Reporter: twelveeighty | Owner: SujaySKumar Type: New feature | Status: new Component: contrib.auth | Version: 1.8 Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 1 Needs tests: 0 | Patch needs improvement: 1 Easy pickings: 1 | UI/UX: 0 ------------------------------+--------------------------------------- Changes (by timgraham):
* status: closed => new * resolution: fixed => Comment: A ticket isn't marked fixed until the patch is committed to Django. Also your patch is missing tests and documentation as outlined in our [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code /submitting-patches/#patch-review-checklist patch review checklist]. Also your patch has a problem if someone is using `extra_context` with a key that clashes with one in `opts` as I mentioned in comment 1. -- Ticket URL: <https://code.djangoproject.com/ticket/24944#comment:4> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.b3cfa7d7840e2b7cc55327723f7b3db2%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.