#25125: Add a check in the checks framework for colliding LANGUAGE_COOKIE_NAME &
SESSION_COOKIE_NAME
----------------------------------+------------------------------------
Reporter: kezabelle | Owner: kswiat
Type: New feature | Status: assigned
Component: contrib.sessions | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
----------------------------------+------------------------------------
Comment (by timgraham):
I'm not sure what you mean by "redundant". I don't think it's very
elegant/useful if that's what you meant.
Regarding a potential implementation, I meant that we should put the check
in "core" because an error that says "The `LANGUAGE_COOKIE_NAME` and
`CSRF_COOKIE_NAME` settings must be different." coming from "sessions"
makes no sense. But if we put the check in core then we have to reference
a contrib setting `SESSION_COOKIE_NAME` in core which is bad because we
shouldn't give special treatment to contrib apps in core code. I suppose
we could have a sessions check and a core check if you are really
enthusiastic about it, but there are more useful tickets that could be
worked on, IMO.
--
Ticket URL: <https://code.djangoproject.com/ticket/25125#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.6a0104f2d8cb25f7ce0d3033e2f70b8b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
