#25164: The django.contrib.auth.views.login does not observe authentication via
RemoteUserMiddleware
------------------------------+--------------------------------------
Reporter: adelton | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Changes (by adelton):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
I wonder if the patch
{{{
+ if hasattr(request, 'user') and request.user.is_authenticated():
+ if not is_safe_url(url=redirect_to, host=request.get_host()):
+ redirect_to = resolve_url(settings.LOGIN_REDIRECT_URL)
+ return HttpResponseRedirect(redirect_to)
+
}}}
that I currently have as proposed in
https://github.com/django/django/pull/4925 for
https://code.djangoproject.com/ticket/25030 isn't actually the correct
thing to do for this case as well.
--
Ticket URL: <https://code.djangoproject.com/ticket/25164#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.d97060947195862912d53d317e4920a8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
