#25374: Admin system check prevents dynamic ModelAdmin attributes
-------------------------------+--------------------------------------
Reporter: mbox | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by mbox):
* has_patch: 0 => 1
Comment:
There's a PR with a proposed fix here:
https://github.com/django/django/pull/5256 which implements the checks on
instances.
This shifts the instance creation to before the checks, and then checks
that instance. It's a fairly small change to the code - most of the patch
is fixing up the test suite to match.
Is it a general design goal/feature that system checks can *only* be
static? If so, then a bunch of these admin system checks would need to be
downgraded to warnings because otherwise they block perfectly valid code.
--
Ticket URL: <https://code.djangoproject.com/ticket/25374#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.bf569d60b5a62e86289b5d68685c386c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
