#25387: ModelAdmin actions don't get access to the ActionForm
-------------------------------+------------------------------------
Reporter: mbox | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: => 0
* needs_docs: => 0
* type: Bug => New feature
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
While I see the simplicity of `self.bound_action_form` from a backwards
compatibility standpoint, I don't think storing state on the `ModelAdmin`
class is thread-safe.
It seems cleaner if the action view were passed `action_form`. A backwards
compatibility shim could be added similar to what was done in
a7c256cb5491bf2a77abdff01638239db5bfd9d5 to support both forms of the
action view for a deprecation period.
--
Ticket URL: <https://code.djangoproject.com/ticket/25387#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.689ac483da1c201356b87775ded574f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
