#25415: Django 1.8 regression: tests no longer run checks
-----------------------------------+------------------------------------
     Reporter:  adamchainz         |                    Owner:  nobody
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.8
     Severity:  Normal             |               Resolution:
     Keywords:                     |             Triage Stage:  Accepted
    Has patch:  1                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  1
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by carljm):

 I see. I doubt that's "the same for everyone else," as until fairly
 recently Django required the "main" database to exist before tests could
 be run at all, because it connected to the main database in order to
 create the test one. But nonetheless you're right that failing to support
 it would still be a regression from 1.7, even if it's not a common need.

 In that case your PR looks pretty reasonable, though I think it would be
 good to add comments at two locations -- at `requires_system_checks =
 False` and at the location where you `call_command('check')` -- explaining
 why this is done instead of a simple `requires_system_checks = True`.

--
Ticket URL: <https://code.djangoproject.com/ticket/25415#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d2c3d5005c6fa829f12b805496fc3927%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to