#25467: Excluding an object with no ID excludes everything.
-------------------------------------+-------------------------------------
Reporter: skorokithakis | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by nemesisdesign):
Relation lookups rely on the primary key to generate the query. Passing an
unsaved instance to lookups like {{{exclude}}} or {{{filter}}} results in
an invalid query, see the two following with the postgres backend:
{{{
>>> Node.objects.exclude(user=u)
(0.001) SELECT "nodes_node"."id", "nodes_node"."user_id" FROM "nodes_node"
WHERE NOT ("nodes_node"."user_id" = NULL AND "nodes_node"."user_id" IS NOT
NULL) LIMIT 21; args=(None,)
}}}
{{{
>>> Node.objects.filter(user=u)
(0.001) SELECT "nodes_node"."id", "nodes_node"."user_id" FROM "nodes_node"
WHERE "nodes_node"."user_id" = NULL LIMIT 21; args=(None,)
[]
}}}
It makes sense to raise an exception to eliminate any ambiguity.
--
Ticket URL: <https://code.djangoproject.com/ticket/25467#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.8eee5616bf906ab214b831e893ec95cc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
