#25751: Translation of strings in a javascript file: Docs are incorrect
-------------------------------------+-------------------------------------
     Reporter:  raratiru             |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:                       |                  Version:  1.8
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:  javascript           |             Triage Stage:  Accepted
  translation                        |
    Has patch:  0                    |      Needs documentation:  1
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by charettes):

 * needs_docs:  0 => 1
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 From what I understand your main `url_patterns` (the one defined by
 `ROOT_URLCONF`) uses `i18n_patterns`.

 In this case `LocaleMiddleware` will behave
 
[https://github.com/django/django/blob/abcdb237bb313d116ce2ac8e90f79f61429afc70/django/middleware/locale.py#L63-L71
 differently] by solely relying on the
 
[https://github.com/django/django/blob/abcdb237bb313d116ce2ac8e90f79f61429afc70/django/utils/translation/trans_real.py#L474-L487
 request path] to determine the active language.

 I guess we should add a note in the `i18n_patterns` documentation stating
 if used all translated content views must also be placed within it.

--
Ticket URL: <https://code.djangoproject.com/ticket/25751#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6313fba34f8207ce022a0a3c03fca29d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to